From bb94d43dcdbfddff40f23944f0e4079f41a30421 Mon Sep 17 00:00:00 2001 From: Josiah Carlson Date: Wed, 1 Apr 2009 01:28:11 +0000 Subject: [PATCH] Fix for failing asyncore tests. --- Doc/library/asyncore.rst | 3 ++- Lib/asyncore.py | 2 +- Lib/test/test_asyncore.py | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Doc/library/asyncore.rst b/Doc/library/asyncore.rst index 4736a9c1110..a2e1b5ed73a 100644 --- a/Doc/library/asyncore.rst +++ b/Doc/library/asyncore.rst @@ -81,7 +81,8 @@ any that have been added to the map during asynchronous service) is closed. +----------------------+----------------------------------------+ | Event | Description | +======================+========================================+ - | ``handle_connect()`` | Implied by the first write event | + | ``handle_connect()`` | Implied by the first read or write | + | | event | +----------------------+----------------------------------------+ | ``handle_close()`` | Implied by a read event with no data | | | available | diff --git a/Lib/asyncore.py b/Lib/asyncore.py index 07b0499fd14..4f1153b760b 100644 --- a/Lib/asyncore.py +++ b/Lib/asyncore.py @@ -401,7 +401,7 @@ class dispatcher: sys.stderr.write('log: %s\n' % str(message)) def log_info(self, message, type='info'): - if __debug__ or type not in self.ignore_log_types: + if type not in self.ignore_log_types: print '%s: %s' % (type, message) def handle_read_event(self): diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py index 72de850f1de..13b39e12190 100644 --- a/Lib/test/test_asyncore.py +++ b/Lib/test/test_asyncore.py @@ -298,6 +298,7 @@ class DispatcherTests(unittest.TestCase): def test_unhandled(self): d = asyncore.dispatcher() + d.ignore_log_types = () # capture output of dispatcher.log_info() (to stdout via print) fp = StringIO() @@ -313,7 +314,7 @@ class DispatcherTests(unittest.TestCase): sys.stdout = stdout lines = fp.getvalue().splitlines() - expected = ['warning: unhandled exception', + expected = ['warning: unhandled incoming priority event', 'warning: unhandled read event', 'warning: unhandled write event', 'warning: unhandled connect event',