From bb4447897a5f141eecf42987a1191a3330c5d7ed Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 9 Apr 2019 18:26:16 +0200 Subject: [PATCH] bpo-36560: regrtest: don't collect the GC twice (GH-12747) dash_R() function of libregrtest doesn't call support.gc_collect() directly anymore: it's already called by dash_R_cleanup(). Call dash_R_cleanup() before starting the loop. --- Lib/test/libregrtest/refleak.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/test/libregrtest/refleak.py b/Lib/test/libregrtest/refleak.py index 0bb8a0a2bf0..235d6bfd3af 100644 --- a/Lib/test/libregrtest/refleak.py +++ b/Lib/test/libregrtest/refleak.py @@ -82,12 +82,14 @@ def dash_R(ns, the_module, test_name, test_func): print(("1234567890"*(repcount//10 + 1))[:repcount], file=sys.stderr, flush=True) + dash_R_cleanup(fs, ps, pic, zdc, abcs) + for i in rep_range: test_func() dash_R_cleanup(fs, ps, pic, zdc, abcs) - # Collect cyclic trash and read memory statistics immediately after. - support.gc_collect() + # dash_R_cleanup() ends with collecting cyclic trash: + # read memory statistics immediately after. alloc_after = getallocatedblocks() rc_after = gettotalrefcount() fd_after = fd_count()