traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

The methods islower(), isupper(), isspace(), isdigit() and istitle() 

gave bogus results for chars in the range 128-255, because their
implementation was using signed characters.  Fixed this by using
unsigned character pointers (as opposed to using Py_CHARMASK()).
This commit is contained in:
Guido van Rossum 2000-05-05 20:44:24 +00:00
parent 3a03d4c4c7
commit b8f820c5a9
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Objects/stringobject.c
View File

@ -1910,8 +1910,8 @@ Return 1 if there are only whitespace characters in S,\n\
static PyObject* static PyObject*
string_isspace(PyStringObject *self, PyObject *args) string_isspace(PyStringObject *self, PyObject *args)
{ {
register const char *p = PyString_AS_STRING(self); register const unsigned char *p = (unsigned char *) PyString_AS_STRING(self);
register const char *e; register const unsigned char *e;
if (!PyArg_NoArgs(args)) if (!PyArg_NoArgs(args))
return NULL; return NULL;
@ -1939,8 +1939,8 @@ Return 1 if there are only digit characters in S,\n\
static PyObject* static PyObject*
string_isdigit(PyStringObject *self, PyObject *args) string_isdigit(PyStringObject *self, PyObject *args)
{ {
register const char *p = PyString_AS_STRING(self); register const unsigned char *p = (unsigned char *) PyString_AS_STRING(self);
register const char *e; register const unsigned char *e;
if (!PyArg_NoArgs(args)) if (!PyArg_NoArgs(args))
return NULL; return NULL;
@ -1968,8 +1968,8 @@ at least one cased character in S, 0 otherwise.";
static PyObject* static PyObject*
string_islower(PyStringObject *self, PyObject *args) string_islower(PyStringObject *self, PyObject *args)
{ {
register const char *p = PyString_AS_STRING(self); register const unsigned char *p = (unsigned char *) PyString_AS_STRING(self);
register const char *e; register const unsigned char *e;
int cased; int cased;
if (!PyArg_NoArgs(args)) if (!PyArg_NoArgs(args))
@ -2000,8 +2000,8 @@ at least one cased character in S, 0 otherwise.";
static PyObject* static PyObject*
string_isupper(PyStringObject *self, PyObject *args) string_isupper(PyStringObject *self, PyObject *args)
{ {
register const char *p = PyString_AS_STRING(self); register const unsigned char *p = (unsigned char *) PyString_AS_STRING(self);
register const char *e; register const unsigned char *e;
int cased; int cased;
if (!PyArg_NoArgs(args)) if (!PyArg_NoArgs(args))
@ -2033,8 +2033,8 @@ ones. Return 0 otherwise.";
static PyObject* static PyObject*
string_istitle(PyStringObject *self, PyObject *args) string_istitle(PyStringObject *self, PyObject *args)
{ {
register const char *p = PyString_AS_STRING(self); register const unsigned char *p = (unsigned char *) PyString_AS_STRING(self);
register const char *e; register const unsigned char *e;
int cased, previous_is_cased; int cased, previous_is_cased;
if (!PyArg_NoArgs(args)) if (!PyArg_NoArgs(args))
@ -2048,7 +2048,7 @@ string_istitle(PyStringObject *self, PyObject *args)
cased = 0; cased = 0;
previous_is_cased = 0; previous_is_cased = 0;
for (; p < e; p++) { for (; p < e; p++) {
register const char ch = *p; register const unsigned char ch = *p;
if (isupper(ch)) { if (isupper(ch)) {
if (previous_is_cased) if (previous_is_cased)