Issue #11659: Fix ResourceWarning in test_subprocess introduced by #11459.

Patch by Ben Hayden.
2011-03-26 21:19:57 +02:00 · 2011-03-26 21:19:57 +02:00 · b8a5769a6d
parent 89461ef8fc
commit b8a5769a6d
3 changed files with 5 additions and 0 deletions
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@ -874,6 +874,7 @@ class ProcessTestCase(BaseTestCase):
                                 stdout=subprocess.PIPE,
                                 bufsize=0)
            f = p.stdout
+            self.addCleanup(f.close)
            try:
                self.assertEqual(f.read(4), b"appl")
                self.assertIn(f, select.select([f], [], [], 0.0)[0])
--- a/Misc/ACKS
+++ b/Misc/ACKS
@ -325,6 +325,7 @@ Jason Harper
 Larry Hastings
 Shane Hathaway
 Rycharde Hawkes
+Ben Hayden
 Jochen Hayek
 Christian Heimes
 Thomas Heller
--- a/Misc/NEWS
+++ b/Misc/NEWS
@ -48,6 +48,9 @@ Core and Builtins
 Library
 -------

+- Issue #11659: Fix ResourceWarning in test_subprocess introduced by #11459.
+  Patch by Ben Hayden.
+
 - Issue #5537: Fix time2isoz() and time2netscape() functions of
  httplib.cookiejar for expiration year greater than 2038 on 32-bit systems.