[3.8] bpo-25872: Fix KeyError in linecache when multithreaded (GH-18007) (GH-20092)

Backporting to 3.8 and adding a NEWS item (I should have added one to the master branch -- oh well).
This commit is contained in:
Andrew Kuchling 2020-05-29 07:59:44 -04:00 committed by GitHub
parent 6381ee077d
commit b86636bff4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions

View File

@ -73,10 +73,10 @@ def checkcache(filename=None):
try:
stat = os.stat(fullname)
except OSError:
del cache[filename]
cache.pop(filename, None)
continue
if size != stat.st_size or mtime != stat.st_mtime:
del cache[filename]
cache.pop(filename, None)
def updatecache(filename, module_globals=None):
@ -86,7 +86,7 @@ def updatecache(filename, module_globals=None):
if filename in cache:
if len(cache[filename]) != 1:
del cache[filename]
cache.pop(filename, None)
if not filename or (filename.startswith('<') and filename.endswith('>')):
return []

View File

@ -0,0 +1,2 @@
:mod:`linecache` could crash with a :exc:`KeyError` when accessed from multiple threads.
Fix by Michael Graczyk.