traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

refactor the warning test.

This commit is contained in:
Gregory P. Smith 2010-12-04 09:59:52 +00:00
parent 10064e9d7a
commit b4162305bb
1 changed files with 11 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
Lib/test/test_subprocess.py
View File

@ -59,31 +59,19 @@ class BaseTestCase(unittest.TestCase):
class DeprecationWarningTests(BaseTestCase): class DeprecationWarningTests(BaseTestCase):
def setUp(self):
BaseTestCase.setUp(self)
self._saved_warn = warnings.warn
self._warn_calls = []
warnings.warn = self._record_warn
def tearDown(self):
warnings.warn = self._saved_warn
BaseTestCase.tearDown(self)
def _record_warn(self, *args):
"""A warnings.warn function that records calls."""
self._warn_calls.append(args)
self._saved_warn(*args)
def testCloseFdsWarning(self): def testCloseFdsWarning(self):
quick_process = [sys.executable, "-c", "import sys; sys.exit(0)"] quick_process = [sys.executable, "-c", "import sys; sys.exit(0)"]
subprocess.call(quick_process, close_fds=True) with warnings.catch_warnings(record=True) as warnlist:
self.assertEqual([], self._warn_calls) warnings.simplefilter("always")
subprocess.call(quick_process, close_fds=False) subprocess.call(quick_process, close_fds=True)
self.assertEqual([], self._warn_calls) self.assertEqual([], warnlist)
self.assertWarns(DeprecationWarning, subprocess.call, quick_process) subprocess.call(quick_process, close_fds=False)
self.assertEqual(1, len(self._warn_calls)) self.assertEqual([], warnlist)
self.assertIn('close_fds parameter was not specified', with self.assertWarns(DeprecationWarning) as wm:
self._warn_calls[0][0]) subprocess.Popen(quick_process).wait()
self.assertEqual(1, len(wm.warnings))
self.assertIn('close_fds parameter was not specified',
str(wm.warnings[0]))
class ProcessTestCase(BaseTestCase): class ProcessTestCase(BaseTestCase):