traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py (GH-22619) 

There are two different `SimpleQueue` types imported (from `multiprocessing.queues` and `queue`) in `Lib/test/test_genericalias.py`, the second one shadowing the first one, making the first one not actually tested. Fix by using different names.

Automerge-Triggered-By: @gvanrossum
This commit is contained in:
Saiyang Gou 2020-10-09 13:00:15 -07:00 committed by GitHub
parent eb38c6b7aa
commit b2c0a43699
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Lib/test/test_genericalias.py
View File

@ -29,7 +29,7 @@ try:
except ImportError: except ImportError:
# multiprocessing.shared_memory is not available on e.g. Android # multiprocessing.shared_memory is not available on e.g. Android
ShareableList = None ShareableList = None
from multiprocessing.queues import SimpleQueue from multiprocessing.queues import SimpleQueue as MPSimpleQueue
from os import DirEntry from os import DirEntry
from re import Pattern, Match from re import Pattern, Match
from types import GenericAlias, MappingProxyType, AsyncGeneratorType from types import GenericAlias, MappingProxyType, AsyncGeneratorType
@ -81,7 +81,7 @@ class BaseTest(unittest.TestCase):
SplitResult, ParseResult, SplitResult, ParseResult,
ValueProxy, ApplyResult, ValueProxy, ApplyResult,
WeakSet, ReferenceType, ref, WeakSet, ReferenceType, ref,
ShareableList, SimpleQueue, ShareableList, MPSimpleQueue,
Future, _WorkItem, Future, _WorkItem,
Morsel] Morsel]
if ctypes is not None: if ctypes is not None: