traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFlags() (GH-19378)" (GH-21390) 

This partially reverts commit 45ec5b99ae.
This commit is contained in:
Victor Stinner 2020-07-08 11:02:23 +02:00 committed by GitHub
parent aebc049557
commit b26a0db8ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Include/object.h
View File

@ -637,8 +637,16 @@ times.
static inline int static inline int
PyType_HasFeature(PyTypeObject *type, unsigned long feature) { PyType_HasFeature(PyTypeObject *type, unsigned long feature)
return ((PyType_GetFlags(type) & feature) != 0); {
unsigned long flags;
#ifdef Py_LIMITED_API
// PyTypeObject is opaque in the limited C API
flags = PyType_GetFlags(type);
#else
flags = type->tp_flags;
#endif
return ((flags & feature) != 0);
} }
#define PyType_FastSubclass(type, flag) PyType_HasFeature(type, flag) #define PyType_FastSubclass(type, flag) PyType_HasFeature(type, flag)

4
Misc/NEWS.d/next/C API/2020-07-08-10-14-52.bpo-40170.N6Qx1i.rst Normal file
View File

@ -0,0 +1,4 @@
Revert :c:func:`PyType_HasFeature` change: it reads again directly the
:c:member:`PyTypeObject.tp_flags` member when the limited C API is not used,
rather than always calling :c:func:`PyType_GetFlags` which hides implementation
details.