traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove creation of a list for row_cast_map in pysqlite_cursor_init() (GH-8494) 

This list is never used: if detect_types is on, this list will be
replaced with another one before row_cast_map is used, if
detect_types is off, row_cast_map is not used at all.
This commit is contained in:
Sergey Fedoseev 2018-07-31 02:11:50 +05:00 committed by Berker Peksag
parent 9045199c5a
commit b229b072a9
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Modules/_sqlite/cursor.c
View File

@ -42,11 +42,7 @@ static int pysqlite_cursor_init(pysqlite_Cursor* self, PyObject* args, PyObject*
Py_XSETREF(self->connection, connection); Py_XSETREF(self->connection, connection);
Py_CLEAR(self->statement); Py_CLEAR(self->statement);
Py_CLEAR(self->next_row); Py_CLEAR(self->next_row);
Py_CLEAR(self->row_cast_map);
Py_XSETREF(self->row_cast_map, PyList_New(0));
if (!self->row_cast_map) {
return -1;
}
Py_INCREF(Py_None); Py_INCREF(Py_None);
Py_XSETREF(self->description, Py_None); Py_XSETREF(self->description, Py_None);
@ -253,6 +249,7 @@ PyObject* _pysqlite_fetch_one_row(pysqlite_Cursor* self)
for (i = 0; i < numcols; i++) { for (i = 0; i < numcols; i++) {
if (self->connection->detect_types) { if (self->connection->detect_types) {
assert(self->row_cast_map != NULL);
converter = PyList_GetItem(self->row_cast_map, i); converter = PyList_GetItem(self->row_cast_map, i);
if (!converter) { if (!converter) {
converter = Py_None; converter = Py_None;