From b0d43ce890adbcfea2e1dff7ba6e76c5c046b61c Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Fri, 20 May 2016 13:05:48 +0200 Subject: [PATCH] asyncio: fix ResourceWarning related to subprocesses Issue #26741: asyncio: BaseSubprocessTransport._process_exited() now copies the return code from the child watched to the returncode attribute of the Popen object. On Python 3.6, it is required to avoid a ResourceWarning. --- Lib/asyncio/base_subprocess.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Lib/asyncio/base_subprocess.py b/Lib/asyncio/base_subprocess.py index 08080bd7012..8fc253c18eb 100644 --- a/Lib/asyncio/base_subprocess.py +++ b/Lib/asyncio/base_subprocess.py @@ -210,6 +210,10 @@ class BaseSubprocessTransport(transports.SubprocessTransport): logger.info('%r exited with return code %r', self, returncode) self._returncode = returncode + if self._proc.returncode is None: + # asyncio uses a child watcher: copy the status into the Popen + # object. On Python 3.6, it is required to avoid a ResourceWarning. + self._proc.returncode = returncode self._call(self._protocol.process_exited) self._try_finish()