bpo-30989: Sort in TimedRotatingFileHandler only when needed. (GH-2812)

TimedRotatingFileHandler.getFilesToDelete() now sorts only when needed.
2017-10-27 09:04:33 +02:00 · 2017-10-27 09:04:33 +02:00 · afad147b59
parent d609b0c24e
commit afad147b59
1 changed files with 1 additions and 1 deletions
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@ -353,10 +353,10 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
                suffix = fileName[plen:]
                if self.extMatch.match(suffix):
                    result.append(os.path.join(dirName, fileName))
-        result.sort()
        if len(result) < self.backupCount:
            result = []
        else:
+            result.sort()
            result = result[:len(result) - self.backupCount]
        return result