traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixes reference leak (#3457)

This commit is contained in:
Steve Dower 2017-09-08 11:35:38 -07:00 committed by GitHub
parent 2b7953d974
commit af8d6b9072
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
PC/_findvs.cpp
View File

@ -161,18 +161,26 @@ static PyObject *find_all_instances()
PyObject *version = nullptr; PyObject *version = nullptr;
PyObject *path = nullptr; PyObject *path = nullptr;
PyObject *packages = nullptr; PyObject *packages = nullptr;
PyObject *tuple = nullptr;
if (FAILED(hr = inst->QueryInterface(&inst2)) || if (FAILED(hr = inst->QueryInterface(&inst2)) ||
!(name = get_install_name(inst2)) || !(name = get_install_name(inst2)) ||
!(version = get_install_version(inst)) || !(version = get_install_version(inst)) ||
!(path = get_install_path(inst)) || !(path = get_install_path(inst)) ||
!(packages = get_installed_packages(inst2)) || !(packages = get_installed_packages(inst2)) ||
PyList_Append(res, PyTuple_Pack(4, name, version, path, packages)) < 0) !(tuple = PyTuple_Pack(4, name, version, path, packages)) ||
PyList_Append(res, tuple) < 0)
goto iter_error; goto iter_error;
Py_DECREF(tuple);
Py_DECREF(packages);
Py_DECREF(path);
Py_DECREF(version);
Py_DECREF(name);
continue; continue;
iter_error: iter_error:
if (inst2) inst2->Release(); if (inst2) inst2->Release();
Py_XDECREF(tuple);
Py_XDECREF(packages); Py_XDECREF(packages);
Py_XDECREF(path); Py_XDECREF(path);
Py_XDECREF(version); Py_XDECREF(version);