traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-31234, socket.create_connection(): Fix ref cycle (#3546)

This commit is contained in:
Victor Stinner 2017-09-13 10:10:10 -07:00 committed by GitHub
parent b157ce1e58
commit acb9fa79fa
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/socket.py
View File

@ -711,6 +711,8 @@ def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT,
if source_address: if source_address:
sock.bind(source_address) sock.bind(source_address)
sock.connect(sa) sock.connect(sa)
# Break explicitly a reference cycle
err = None
return sock return sock
except error as _: except error as _:

2
Misc/NEWS.d/next/Library/2017-09-13-18-05-56.bpo-31234.lGkcPg.rst Normal file
View File

@ -0,0 +1,2 @@
socket.create_connection() now fixes manually a reference cycle: clear the
variable storing the last exception on success.