close file properly

2010-10-31 01:35:53 +00:00 · 2010-10-31 01:35:53 +00:00 · aa7cec0ac4
parent 556c7355dd
commit aa7cec0ac4
1 changed files with 2 additions and 1 deletions
--- a/Lib/test/test_popen.py
+++ b/Lib/test/test_popen.py
@ -22,7 +22,8 @@ class PopenTest(unittest.TestCase):
    def _do_test_commandline(self, cmdline, expected):
        cmd = '%s -c "import sys; print(sys.argv)" %s'
        cmd = cmd % (python, cmdline)
-        data = os.popen(cmd).read()
+        with os.popen(cmd) as p:
+            data = p.read()
        got = eval(data)[1:] # strip off argv[0]
        self.assertEqual(got, expected)