traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Issue #20604: Added missed invalid mode in error message of socket.makefile(). 

Based on patch by Franck Michea.
This commit is contained in:
Serhiy Storchaka 2014-11-19 12:34:07 +02:00
parent 1d922d0ce9 fca2fc090c
commit a9568bb44a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Lib/socket.py
View File

@ -209,9 +209,8 @@ class socket(_socket.socket):
except the only mode characters supported are 'r', 'w' and 'b'. except the only mode characters supported are 'r', 'w' and 'b'.
The semantics are similar too. (XXX refactor to share code?) The semantics are similar too. (XXX refactor to share code?)
""" """
for c in mode: if not set(mode) <= {"r", "w", "b"}:
if c not in {"r", "w", "b"}: raise ValueError("invalid mode %r (only r, w, b allowed)" % (mode,))
raise ValueError("invalid mode %r (only r, w, b allowed)")
writing = "w" in mode writing = "w" in mode
reading = "r" in mode or not writing reading = "r" in mode or not writing
assert reading or writing assert reading or writing