traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-36517: Raise error on multiple inheritance with NamedTuple (GH-19363)

This commit is contained in:
Serhiy Storchaka 2020-04-04 21:31:30 +03:00 committed by GitHub
parent 1ae6445391
commit a94e6272f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Lib/test/test_typing.py
View File

@ -3626,6 +3626,13 @@ class XMethBad2(NamedTuple):
return 'no chance for this as well' return 'no chance for this as well'
""") """)
def test_multiple_inheritance(self):
class A:
pass
with self.assertRaises(TypeError):
class X(NamedTuple, A):
x: int
def test_namedtuple_keyword_usage(self): def test_namedtuple_keyword_usage(self):
LocalEmployee = NamedTuple("LocalEmployee", name=str, age=int) LocalEmployee = NamedTuple("LocalEmployee", name=str, age=int)
nick = LocalEmployee('Nick', 25) nick = LocalEmployee('Nick', 25)

3
Lib/typing.py
View File

@ -1728,6 +1728,9 @@ class NamedTupleMeta(type):
def __new__(cls, typename, bases, ns): def __new__(cls, typename, bases, ns):
if ns.get('_root', False): if ns.get('_root', False):
return super().__new__(cls, typename, bases, ns) return super().__new__(cls, typename, bases, ns)
if len(bases) > 1:
raise TypeError("Multiple inheritance with NamedTuple is not supported")
assert bases[0] is NamedTuple
types = ns.get('__annotations__', {}) types = ns.get('__annotations__', {})
nm_tpl = _make_nmtuple(typename, types.items()) nm_tpl = _make_nmtuple(typename, types.items())
defaults = [] defaults = []

2
Misc/NEWS.d/next/Library/2020-04-04-17-49-39.bpo-36517.Ilj1IJ.rst Normal file
View File

@ -0,0 +1,2 @@
Multiple inheritance with :class:`typing.NamedTuple` now raises an error
instead of silently ignoring other types.