From a8eb58546b37a7cd5f332f019bb07388f5212c2d Mon Sep 17 00:00:00 2001 From: "A. Jesse Jiryu Davis" Date: Mon, 4 Jun 2018 06:57:08 -0400 Subject: [PATCH] bpo-31849: Fix warning in pyhash.c (GH-6799) --- .../2018-05-14-11-00-00.bpo-31849.EmHaH4.rst | 1 + Python/pyhash.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Core and Builtins/2018-05-14-11-00-00.bpo-31849.EmHaH4.rst diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-05-14-11-00-00.bpo-31849.EmHaH4.rst b/Misc/NEWS.d/next/Core and Builtins/2018-05-14-11-00-00.bpo-31849.EmHaH4.rst new file mode 100644 index 00000000000..876a3cf0aa1 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2018-05-14-11-00-00.bpo-31849.EmHaH4.rst @@ -0,0 +1 @@ +Fix signed/unsigned comparison warning in pyhash.c. diff --git a/Python/pyhash.c b/Python/pyhash.c index 6fc12fde3fc..4c0b929586f 100644 --- a/Python/pyhash.c +++ b/Python/pyhash.c @@ -272,8 +272,8 @@ fnv(const void *src, Py_ssize_t len) x = (_PyHASH_MULTIPLIER * x) ^ (Py_uhash_t) *p++; x ^= (Py_uhash_t) len; x ^= (Py_uhash_t) _Py_HashSecret.fnv.suffix; - if (x == -1) { - x = -2; + if (x == (Py_uhash_t) -1) { + x = (Py_uhash_t) -2; } return x; }