traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

#2501 xml.sax.parser doesn't terminate when given a filename; enable some more tests! 

Reviewed by myself
This commit is contained in:
Benjamin Peterson 2008-09-04 02:22:52 +00:00
parent ecaab837b6
commit a7f4f5a772
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Lib/test/test_sax.py
View File

@ -446,8 +446,7 @@ class ExpatReaderTest(XmlTestBase):
# ===== InputSource support
def XXXtest_expat_inpsource_filename(self):
# FIXME: test blocks indefinitely
def test_expat_inpsource_filename(self):
parser = create_parser()
result = StringIO()
xmlgen = XMLGenerator(result)
@ -457,8 +456,7 @@ class ExpatReaderTest(XmlTestBase):
self.assertEquals(result.getvalue(), xml_test_out)
def XXXtest_expat_inpsource_sysid(self):
# FIXME: test blocks indefinitely
def test_expat_inpsource_sysid(self):
parser = create_parser()
result = StringIO()
xmlgen = XMLGenerator(result)
@ -531,8 +529,7 @@ class ExpatReaderTest(XmlTestBase):
self.assertEquals(parser.getPublicId(), None)
self.assertEquals(parser.getLineNumber(), 1)
def XXXtest_expat_locator_withinfo(self):
# FIXME: test blocks indefinitely
def test_expat_locator_withinfo(self):
result = StringIO()
xmlgen = XMLGenerator(result)
parser = create_parser()

2
Lib/xml/sax/xmlreader.py
View File

@ -119,7 +119,7 @@ class IncrementalParser(XMLReader):
self.prepareParser(source)
file = source.getByteStream()
buffer = file.read(self._bufsize)
while buffer != "":
while buffer:
self.feed(buffer)
buffer = file.read(self._bufsize)
self.close()