From a5e31091540a0c63ea1a4c9cafad5801480c33b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20v=2E=20L=C3=B6wis?= Date: Sat, 4 Sep 2010 14:38:09 +0000 Subject: [PATCH] Issue #1303434: Include PDBs in release. Patch by James Lee and Daniel Stutzbach. --- Misc/NEWS | 2 ++ Tools/msi/msi.py | 17 ++++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index 3c162a6d99c..bf907a5be2e 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -381,6 +381,8 @@ Tests Build ----- +- Issue #1303434: Generate ZIP file containing all PDBs. + - Issue #9193: PEP 3149 is accepted. - Issue #3101: Helper functions _add_one_to_index_C() and diff --git a/Tools/msi/msi.py b/Tools/msi/msi.py index a9bbc1d3794..31869c73a5a 100644 --- a/Tools/msi/msi.py +++ b/Tools/msi/msi.py @@ -1,7 +1,7 @@ # Python MSI Generator # (C) 2003 Martin v. Loewis # See "FOO" in comments refers to MSDN sections with the title FOO. -import msilib, schema, sequence, os, glob, time, re, shutil +import msilib, schema, sequence, os, glob, time, re, shutil, zipfile from msilib import Feature, CAB, Directory, Dialog, Binary, add_data import uisample from win32com.client import constants @@ -31,6 +31,8 @@ PCBUILD="PCbuild" MSVCR = "90" # Name of certificate in default store to sign MSI with certname = None +# Make a zip file containing the PDB files for this build? +pdbzip = True try: from config import * @@ -1316,6 +1318,16 @@ def add_registry(db): ]) db.Commit() +def build_pdbzip(): + pdbexclude = ['kill_python.pdb', 'make_buildinfo.pdb', + 'make_versioninfo.pdb'] + path = "python-%s%s-pdb.zip" % (full_current_version, msilib.arch_ext) + pdbzip = zipfile.ZipFile(path, 'w') + for f in glob.glob1(os.path.join(srcdir, PCBUILD), "*.pdb"): + if f not in pdbexclude and not f.endswith('_d.pdb'): + pdbzip.write(os.path.join(srcdir, PCBUILD, f), f) + pdbzip.close() + db,msiname = build_database() try: add_features(db) @@ -1398,3 +1410,6 @@ merge(msiname, "SharedCRT", "TARGETDIR", modules) # the certificate subject, e.g. "Python Software Foundation" if certname: os.system('signtool sign /n "%s" /t http://timestamp.verisign.com/scripts/timestamp.dll %s' % (certname, msiname)) + +if pdbzip: + build_pdbzip()