traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-25684: ttk.OptionMenu radiobuttons weren't unique (#2276) 

between instances of OptionMenu.
This commit is contained in:
csabella 2017-07-31 05:30:09 -04:00 committed by Serhiy Storchaka
parent e8eb17b2c1
commit a568e52733
3 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Lib/tkinter/test/test_ttk/test_extensions.py
View File

@ -291,6 +291,31 @@ class OptionMenuTest(AbstractTkTest, unittest.TestCase):
optmenu.destroy()
def test_unique_radiobuttons(self):
# check that radiobuttons are unique across instances (bpo25684)
items = ('a', 'b', 'c')
default = 'a'
optmenu = ttk.OptionMenu(self.root, self.textvar, default, *items)
textvar2 = tkinter.StringVar(self.root)
optmenu2 = ttk.OptionMenu(self.root, textvar2, default, *items)
optmenu.pack()
optmenu.wait_visibility()
optmenu2.pack()
optmenu2.wait_visibility()
optmenu['menu'].invoke(1)
optmenu2['menu'].invoke(2)
optmenu_stringvar_name = optmenu['menu'].entrycget(0, 'variable')
optmenu2_stringvar_name = optmenu2['menu'].entrycget(0, 'variable')
self.assertNotEqual(optmenu_stringvar_name,
optmenu2_stringvar_name)
self.assertEqual(self.root.tk.globalgetvar(optmenu_stringvar_name),
items[1])
self.assertEqual(self.root.tk.globalgetvar(optmenu2_stringvar_name),
items[2])
optmenu.destroy()
optmenu2.destroy()
tests_gui = (LabeledScaleTest, OptionMenuTest)

3
Lib/tkinter/ttk.py
View File

@ -1635,7 +1635,8 @@ class OptionMenu(Menubutton):
menu.delete(0, 'end')
for val in values:
menu.add_radiobutton(label=val,
command=tkinter._setit(self._variable, val, self._callback))
command=tkinter._setit(self._variable, val, self._callback),
variable=self._variable)
if default:
self._variable.set(default)

2
Misc/NEWS.d/next/Library/2017-07-17-11-35-00.bpo-25684.usELVx.rst Normal file
View File

@ -0,0 +1,2 @@
Change ``ttk.OptionMenu`` radiobuttons to be unique across instances of
``OptionMenu``.