traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-35918: Remove broken has_key method and add test (#11819)

This commit is contained in:
Rémi Lapeyre 2019-02-12 01:37:24 +01:00 committed by Giampaolo Rodola
parent 522346d792
commit a31f4cc881
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/multiprocessing/managers.py
View File

@ -1135,7 +1135,7 @@ class ListProxy(BaseListProxy):
DictProxy = MakeProxyType('DictProxy', ( DictProxy = MakeProxyType('DictProxy', (
'__contains__', '__delitem__', '__getitem__', '__iter__', '__len__', '__contains__', '__delitem__', '__getitem__', '__iter__', '__len__',
'__setitem__', 'clear', 'copy', 'get', 'has_key', 'items', '__setitem__', 'clear', 'copy', 'get', 'items',
'keys', 'pop', 'popitem', 'setdefault', 'update', 'values' 'keys', 'pop', 'popitem', 'setdefault', 'update', 'values'
)) ))
DictProxy._method_to_typeid_ = { DictProxy._method_to_typeid_ = {

2
Lib/test/_test_multiprocessing.py
View File

@ -4897,8 +4897,6 @@ class TestSyncManagerTypes(unittest.TestCase):
assert len(obj) == 1 assert len(obj) == 1
assert obj['foo'] == 5 assert obj['foo'] == 5
assert obj.get('foo') == 5 assert obj.get('foo') == 5
# TODO: fix https://bugs.python.org/issue35918
# assert obj.has_key('foo')
assert list(obj.items()) == [('foo', 5)] assert list(obj.items()) == [('foo', 5)]
assert list(obj.keys()) == ['foo'] assert list(obj.keys()) == ['foo']
assert list(obj.values()) == [5] assert list(obj.values()) == [5]

2
Misc/NEWS.d/next/Library/2019-02-11-16-23-10.bpo-35918.oGDlpT.rst Normal file
View File

@ -0,0 +1,2 @@
Removed broken ``has_key`` method from
multiprocessing.managers.SyncManager.dict. Contributed by Rémi Lapeyre.