Added tests for issue #20501.

This commit is contained in:
Serhiy Storchaka 2014-02-26 21:03:19 +02:00
commit 9fff849dbf
1 changed files with 38 additions and 0 deletions

View File

@ -260,6 +260,24 @@ class FileInputTests(unittest.TestCase):
fi.readline() fi.readline()
self.assertTrue(custom_open_hook.invoked, "openhook not invoked") self.assertTrue(custom_open_hook.invoked, "openhook not invoked")
def test_readline(self):
with open(TESTFN, 'wb') as f:
f.write(b'A\nB\r\nC\r')
# Fill TextIOWrapper buffer.
f.write(b'123456789\n' * 1000)
# Issue #20501: readline() shouldn't read whole file.
f.write(b'\x80')
self.addCleanup(safe_unlink, TESTFN)
with FileInput(files=TESTFN,
openhook=hook_encoded('ascii'), bufsize=8) as fi:
self.assertEqual(fi.readline(), 'A\n')
self.assertEqual(fi.readline(), 'B\n')
self.assertEqual(fi.readline(), 'C\n')
with self.assertRaises(UnicodeDecodeError):
# Read to the end of file.
list(fi)
def test_context_manager(self): def test_context_manager(self):
try: try:
t1 = writeTmp(1, ["A\nB\nC"]) t1 = writeTmp(1, ["A\nB\nC"])
@ -837,6 +855,26 @@ class Test_hook_encoded(unittest.TestCase):
self.assertIs(kwargs.pop('encoding'), encoding) self.assertIs(kwargs.pop('encoding'), encoding)
self.assertFalse(kwargs) self.assertFalse(kwargs)
def test_modes(self):
# Unlikely UTF-7 is locale encoding
with open(TESTFN, 'wb') as f:
f.write(b'A\nB\r\nC\rD+IKw-')
self.addCleanup(safe_unlink, TESTFN)
def check(mode, expected_lines):
with FileInput(files=TESTFN, mode=mode,
openhook=hook_encoded('utf-7')) as fi:
lines = list(fi)
self.assertEqual(lines, expected_lines)
check('r', ['A\n', 'B\n', 'C\n', 'D\u20ac'])
with self.assertWarns(DeprecationWarning):
check('rU', ['A\n', 'B\n', 'C\n', 'D\u20ac'])
with self.assertWarns(DeprecationWarning):
check('U', ['A\n', 'B\n', 'C\n', 'D\u20ac'])
with self.assertRaises(ValueError):
check('rb', ['A\n', 'B\r\n', 'C\r', 'D\u20ac'])
if __name__ == "__main__": if __name__ == "__main__":
unittest.main() unittest.main()