Merged revisions 84408-84409 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84408 | antoine.pitrou | 2010-09-01 23:14:16 +0200 (mer., 01 sept. 2010) | 4 lines

  Issue #9737: Fix a crash when trying to delete a slice or an item from
  a memoryview object.
........
  r84409 | antoine.pitrou | 2010-09-01 23:14:46 +0200 (mer., 01 sept. 2010) | 3 lines

  Fix a compilation warning
........
This commit is contained in:
Antoine Pitrou 2010-09-01 21:17:34 +00:00
parent 54f824f092
commit 9cf85f144e
3 changed files with 18 additions and 1 deletions

View File

@ -117,6 +117,15 @@ class AbstractMemoryTests:
m = None m = None
self.assertEquals(sys.getrefcount(b), oldrefcount) self.assertEquals(sys.getrefcount(b), oldrefcount)
def test_delitem(self):
for tp in self._types:
b = tp(self._source)
m = self._view(b)
with self.assertRaises(TypeError):
del m[1]
with self.assertRaises(TypeError):
del m[1:4]
def test_tobytes(self): def test_tobytes(self):
for tp in self._types: for tp in self._types:
m = self._view(tp(self._source)) m = self._view(tp(self._source))

View File

@ -12,6 +12,9 @@ What's New in Python 2.7.1?
Core and Builtins Core and Builtins
----------------- -----------------
- Issue #9737: Fix a crash when trying to delete a slice or an item from
a memoryview object.
- Restore GIL in nis_cat in case of error. - Restore GIL in nis_cat in case of error.
- Issue #9688: __basicsize__ and __itemsize__ must be accessed as Py_ssize_t. - Issue #9688: __basicsize__ and __itemsize__ must be accessed as Py_ssize_t.

View File

@ -179,7 +179,7 @@ _indirect_copy_nd(char *dest, Py_buffer *view, char fort)
int k; int k;
Py_ssize_t elements; Py_ssize_t elements;
char *ptr; char *ptr;
void (*func)(int, Py_ssize_t *, Py_ssize_t *); void (*func)(int, Py_ssize_t *, const Py_ssize_t *);
if (view->ndim > PY_SSIZE_T_MAX / sizeof(Py_ssize_t)) { if (view->ndim > PY_SSIZE_T_MAX / sizeof(Py_ssize_t)) {
PyErr_NoMemory(); PyErr_NoMemory();
@ -639,6 +639,11 @@ memory_ass_sub(PyMemoryViewObject *self, PyObject *key, PyObject *value)
"cannot modify read-only memory"); "cannot modify read-only memory");
return -1; return -1;
} }
if (value == NULL) {
PyErr_SetString(PyExc_TypeError,
"cannot delete memory");
return -1;
}
if (view->ndim != 1) { if (view->ndim != 1) {
PyErr_SetNone(PyExc_NotImplementedError); PyErr_SetNone(PyExc_NotImplementedError);
return -1; return -1;