From 9973d74b2d63ebd6a49d239b49f01fe823705b97 Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Thu, 15 Aug 2002 19:41:06 +0000 Subject: [PATCH] long_mul(): Simplified exit code. In particular, k_mul() returns a normalized result, so no point to normalizing it again. The number of test+branches was also excessive. --- Objects/longobject.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/Objects/longobject.c b/Objects/longobject.c index 348dcc49dbd..2343db81339 100644 --- a/Objects/longobject.c +++ b/Objects/longobject.c @@ -1878,18 +1878,12 @@ long_mul(PyLongObject *v, PyLongObject *w) } z = k_mul(a, b); - if(z == NULL) { - Py_DECREF(a); - Py_DECREF(b); - return NULL; - } - if (a->ob_size < 0) - z->ob_size = -(z->ob_size); - if (b->ob_size < 0) + /* Negate if exactly one of the inputs is negative. */ + if (((a->ob_size ^ b->ob_size) < 0) && z) z->ob_size = -(z->ob_size); Py_DECREF(a); Py_DECREF(b); - return (PyObject *) long_normalize(z); + return (PyObject *)z; } /* The / and % operators are now defined in terms of divmod().