From 9810427e4160fea1fda5a041e0bc11efe5f47033 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Wed, 12 Jan 2011 19:27:17 +0000 Subject: [PATCH] Merged revisions 87895 via svnmerge from svn+ssh://pythondev@svn.python.org/python/branches/py3k MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ........ r87895 | lukasz.langa | 2011-01-09 12:18:53 -0600 (Sun, 09 Jan 2011) | 5 lines #10874: test_urllib2 shouldn't use `is` operator for comparing strings Patch by Adreas Stührk. ........ --- Lib/test/test_urllib2.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py index b74320d2acc..789dcd34422 100644 --- a/Lib/test/test_urllib2.py +++ b/Lib/test/test_urllib2.py @@ -748,7 +748,7 @@ class HandlerTests(unittest.TestCase): else: self.assertTrue(o.req is req) self.assertEqual(req.type, "ftp") - self.assertEqual(req.type is "ftp", ftp) + self.assertEqual(req.type == "ftp", ftp) def test_http(self):