traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-30830: logging.config.listen() calls server_close() (#3524) 

The ConfigSocketReceiver.serve_until_stopped() method from
logging.config.listen() now calls server_close() (of
socketserver.ThreadingTCPServer) rather than closing manually the
socket.

While this change has no effect yet, it will help to prevent dangling
threads once ThreadingTCPServer.server_close() will join spawned
threads (bpo-31233).
This commit is contained in:
Victor Stinner 2017-09-13 01:44:08 -07:00 committed by GitHub
parent b8d1b9d7c6
commit 97d7e65dfe
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/logging/config.py
View File

@ -887,7 +887,7 @@ def listen(port=DEFAULT_LOGGING_CONFIG_PORT, verify=None):
logging._acquireLock() logging._acquireLock()
abort = self.abort abort = self.abort
logging._releaseLock() logging._releaseLock()
self.socket.close() self.server_close()
class Server(threading.Thread): class Server(threading.Thread):