traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

closes bpo-37405: Make socket.getsockname() always return a tuple for AF_CAN. (GH-14392) 

This fixes a regression from 3.5. In recent releases, `getsockname()` in the AF_CAN case has returned a string.
This commit is contained in:
bggardner 2019-09-12 06:02:48 -04:00 committed by Benjamin Peterson
parent 64535fc6c0
commit 954900a3f9
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Lib/test/test_socket.py
View File

@ -1948,7 +1948,9 @@ class BasicCANTest(unittest.TestCase):
def testBindAny(self): def testBindAny(self):
with socket.socket(socket.PF_CAN, socket.SOCK_RAW, socket.CAN_RAW) as s: with socket.socket(socket.PF_CAN, socket.SOCK_RAW, socket.CAN_RAW) as s:
s.bind(('', )) address = ('', )
s.bind(address)
self.assertEqual(s.getsockname(), address)
def testTooLongInterfaceName(self): def testTooLongInterfaceName(self):
# most systems limit IFNAMSIZ to 16, take 1024 to be sure # most systems limit IFNAMSIZ to 16, take 1024 to be sure

2
Misc/NEWS.d/next/Library/2019-09-11-20-27-41.bpo-37405.MG5xiY.rst Normal file
View File

@ -0,0 +1,2 @@
Fixed regression bug for socket.getsockname() for non-CAN_ISOTP AF_CAN
address family sockets by returning a 1-tuple instead of string.

2
Modules/socketmodule.c
View File

@ -1563,7 +1563,7 @@ makesockaddr(SOCKET_T sockfd, struct sockaddr *addr, size_t addrlen, int proto)
#endif /* CAN_ISOTP */ #endif /* CAN_ISOTP */
default: default:
{ {
return Py_BuildValue("O&", PyUnicode_DecodeFSDefault, return Py_BuildValue("(O&)", PyUnicode_DecodeFSDefault,
ifname); ifname);
} }
} }