From 926fd4ee32de00ddb44df111f830678e2bcc6524 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 5 May 2010 12:40:49 +0000 Subject: [PATCH] Issue #8313: traceback.format_exception_only() encodes unicode message to ASCII with backslashreplace error handler if str(value) failed --- Lib/test/test_traceback.py | 9 +++++++++ Lib/traceback.py | 10 ++++++++-- Misc/NEWS | 3 +++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py index c79961e0c4e..811feac4990 100644 --- a/Lib/test/test_traceback.py +++ b/Lib/test/test_traceback.py @@ -159,6 +159,15 @@ def test(): err = traceback.format_exception_only(None, None) self.assertEqual(err, ['None\n']) + def test_unicode(self): + err = AssertionError('\xff') + lines = traceback.format_exception_only(type(err), err) + self.assertEqual(lines, ['AssertionError: \xff\n']) + + err = AssertionError(u'\xe9') + lines = traceback.format_exception_only(type(err), err) + self.assertEqual(lines, ['AssertionError: \\xe9\n']) + class TracebackFormatTests(unittest.TestCase): diff --git a/Lib/traceback.py b/Lib/traceback.py index 8d28afc0cd0..8cb9e281fce 100644 --- a/Lib/traceback.py +++ b/Lib/traceback.py @@ -211,8 +211,14 @@ def _format_final_exc_line(etype, value): def _some_str(value): try: return str(value) - except: - return '' % type(value).__name__ + except Exception: + pass + try: + value = unicode(value) + return value.encode("ascii", "backslashreplace") + except Exception: + pass + return '' % type(value).__name__ def print_exc(limit=None, file=None): diff --git a/Misc/NEWS b/Misc/NEWS index 38fae31dc00..4f8684ae525 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -39,6 +39,9 @@ Core and Builtins Library ------- +- Issue #8313: traceback.format_exception_only() encodes unicode message to + ASCII with backslashreplace error handler if str(value) failed + - Issue #8567: Fix precedence of signals in Decimal module: when a Decimal operation raises multiple signals and more than one of those signals is trapped, the specification determines the order in which