Issue #22770: Prevent some Tk segfaults on OS X when running gui tests.

When running tests in subprocesses with the regrtest -j option, a bug
in Cocoa Tk can result in a Tcl segfault.  Avoid the problem by forcing
Tk to fully initialize as an OS X gui process before destroying the
Tcl instance and creating another. (Original patch by Serhiy Storchaka)
This commit is contained in:
Ned Deily 2014-11-01 19:29:22 -07:00
parent aa3ea7ee78
commit 91f01e175a
2 changed files with 4 additions and 3 deletions

View File

@ -461,12 +461,11 @@ def _is_gui_available():
reason = "cannot run without OS X gui process" reason = "cannot run without OS X gui process"
# check on every platform whether tkinter can actually do anything # check on every platform whether tkinter can actually do anything
# but skip the test on OS X because it can cause segfaults in Cocoa Tk if not reason:
# when running regrtest with the -j option (multiple threads/subprocesses)
if (not reason) and (sys.platform != 'darwin'):
try: try:
from tkinter import Tk from tkinter import Tk
root = Tk() root = Tk()
root.update()
root.destroy() root.destroy()
except Exception as e: except Exception as e:
err_string = str(e) err_string = str(e)

View File

@ -113,6 +113,8 @@ Tests
- Issue #21456: Skip two tests in test_urllib2net.py if _ssl module not - Issue #21456: Skip two tests in test_urllib2net.py if _ssl module not
present. Patch by Remi Pointel. present. Patch by Remi Pointel.
- Issue #22770: Prevent some Tk segfaults on OS X when running gui tests.
Build Build
----- -----