From 91a57216c95b84aa883816fcfacfdd6b91827113 Mon Sep 17 00:00:00 2001 From: Neal Norwitz Date: Sun, 12 Aug 2007 17:11:13 +0000 Subject: [PATCH] Fix memory leak in os.readlink --- Modules/posixmodule.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index 8a78d8c152e..24c9e15537d 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -5783,7 +5783,10 @@ posix_readlink(PyObject *self, PyObject *args) return NULL; #ifdef Py_USING_UNICODE v = PySequence_GetItem(args, 0); - if (v == NULL) return NULL; + if (v == NULL) { + PyMem_Free(path); + return NULL; + } if (PyUnicode_Check(v)) { arg_is_unicode = 1; @@ -5795,8 +5798,9 @@ posix_readlink(PyObject *self, PyObject *args) n = readlink(path, buf, (int) sizeof buf); Py_END_ALLOW_THREADS if (n < 0) - return posix_error_with_filename(path); + return posix_error_with_allocated_filename(path); + PyMem_Free(path); v = PyString_FromStringAndSize(buf, n); #ifdef Py_USING_UNICODE if (arg_is_unicode) {