traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merged revisions 77355 via svnmerge from 

svn+ssh://pythondev@svn.python.org/python/branches/py3k

................
  r77355 | antoine.pitrou | 2010-01-07 18:57:31 +0100 (jeu., 07 janv. 2010) | 18 lines

  Merged revisions 77352-77354 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r77352 | antoine.pitrou | 2010-01-07 18:46:49 +0100 (jeu., 07 janv. 2010) | 5 lines

    Issue #7455: Fix possible crash in cPickle on invalid input.  Patch by
    Florent Xicluna.
  ........
    r77353 | antoine.pitrou | 2010-01-07 18:49:37 +0100 (jeu., 07 janv. 2010) | 3 lines

    Fix attribution. Florent actually repackaged and reviewed Victor's patch (sorry!).
  ........
    r77354 | antoine.pitrou | 2010-01-07 18:54:10 +0100 (jeu., 07 janv. 2010) | 3 lines

    Fix reattribution mistake when fixing attribution mistake!
  ........
................
This commit is contained in:
Antoine Pitrou 2010-01-07 18:02:53 +00:00
parent 93a59653a4
commit 901d81e672
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/test/pickletester.py
View File

@ -1142,6 +1142,9 @@ class AbstractPickleModuleTests(unittest.TestCase):
# Test issue4298 # Test issue4298
s = bytes([0x58, 0, 0, 0, 0x54]) s = bytes([0x58, 0, 0, 0, 0x54])
self.assertRaises(EOFError, pickle.loads, s) self.assertRaises(EOFError, pickle.loads, s)
# Test issue7455
s = b'0'
self.assertRaises(pickle.UnpicklingError, pickle.loads, s)
class AbstractPersistentPicklerTests(unittest.TestCase): class AbstractPersistentPicklerTests(unittest.TestCase):

3
Misc/NEWS
View File

@ -61,6 +61,9 @@ Core and Builtins
Library Library
------- -------
- Issue #7455: Fix possible crash in cPickle on invalid input. Patch by
Victor Stinner.
- Issue #6511: ZipFile now raises BadZipfile (instead of an IOError) when - Issue #6511: ZipFile now raises BadZipfile (instead of an IOError) when
opening an empty or very small file. opening an empty or very small file.

2
Modules/_pickle.c
View File

@ -3729,7 +3729,7 @@ load_pop(UnpicklerObject *self)
*/ */
if (self->num_marks > 0 && self->marks[self->num_marks - 1] == len) { if (self->num_marks > 0 && self->marks[self->num_marks - 1] == len) {
self->num_marks--; self->num_marks--;
} else if (len >= 0) { } else if (len > 0) {
len--; len--;
Py_DECREF(self->stack->data[len]); Py_DECREF(self->stack->data[len]);
self->stack->length = len; self->stack->length = len;