From 8e3708d88ba868eb2d915f0793c0bc0bb5f58b50 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 26 Nov 2013 00:45:47 +0100 Subject: [PATCH] Issue #18874: allow to call tracemalloc.Snapshot.statistics(cumulative=True) with traceback_limit=1 --- Doc/library/tracemalloc.rst | 3 +-- Lib/tracemalloc.py | 4 ---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/Doc/library/tracemalloc.rst b/Doc/library/tracemalloc.rst index 2e1902e9591..be716e921ec 100644 --- a/Doc/library/tracemalloc.rst +++ b/Doc/library/tracemalloc.rst @@ -479,8 +479,7 @@ Snapshot If *cumulative* is ``True``, cumulate size and count of memory blocks of all frames of the traceback of a trace, not only the most recent frame. The cumulative mode can only be used with *group_by* equals to - ``'filename'`` and ``'lineno'`` and :attr:`traceback_limit` greater than - ``1``. + ``'filename'`` and ``'lineno'``. The result is sorted from the biggest to the smallest by: :attr:`Statistic.size`, :attr:`Statistic.count` and then by diff --git a/Lib/tracemalloc.py b/Lib/tracemalloc.py index 7780eca77d7..d51f1617ece 100644 --- a/Lib/tracemalloc.py +++ b/Lib/tracemalloc.py @@ -380,10 +380,6 @@ class Snapshot: if cumulative and key_type not in ('lineno', 'filename'): raise ValueError("cumulative mode cannot by used " "with key type %r" % key_type) - if cumulative and self.traceback_limit < 2: - raise ValueError("cumulative mode needs tracebacks with at least " - "2 frames, traceback limit is %s" - % self.traceback_limit) stats = {} tracebacks = {}