Issue #11603: Fix a crash when __str__ is rebound as __repr__.

Patch by Andreas Stührk.
This commit is contained in:
Antoine Pitrou 2011-07-15 21:15:07 +02:00
parent e22813067e
commit 8cdc40e3b0
3 changed files with 12 additions and 1 deletions

View File

@ -4252,6 +4252,14 @@ order (MRO) for bases """
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
str.__add__(fake_str, "abc") str.__add__(fake_str, "abc")
def test_repr_as_str(self):
# Issue #11603: crash or infinite loop when rebinding __str__ as
# __repr__.
class Foo:
pass
Foo.__repr__ = Foo.__str__
foo = Foo()
str(foo)
class DictProxyTests(unittest.TestCase): class DictProxyTests(unittest.TestCase):
def setUp(self): def setUp(self):

View File

@ -13,6 +13,9 @@ Core and Builtins
Library Library
------- -------
- Issue #11603: Fix a crash when __str__ is rebound as __repr__. Patch by
Andreas Stührk.
What's New in Python 3.1.4? What's New in Python 3.1.4?
=========================== ===========================

View File

@ -2821,7 +2821,7 @@ object_str(PyObject *self)
unaryfunc f; unaryfunc f;
f = Py_TYPE(self)->tp_repr; f = Py_TYPE(self)->tp_repr;
if (f == NULL) if (f == NULL || f == object_str)
f = object_repr; f = object_repr;
return f(self); return f(self);
} }