From 29267c81ce2bca421f1ba044491200b41ed5cfd2 Mon Sep 17 00:00:00 2001
From: Ezio Melotti <ezio.melotti@gmail.com>
Date: Sat, 23 Feb 2013 05:52:46 +0200
Subject: [PATCH] #17249: convert a test in test_capi to use unittest and reap
 threads.

---
 Lib/test/test_capi.py | 56 +++++++++++++++++++++----------------------
 Misc/NEWS             |  2 ++
 2 files changed, 30 insertions(+), 28 deletions(-)

diff --git a/Lib/test/test_capi.py b/Lib/test/test_capi.py
index e7afa55fd12..d61bf363dc3 100644
--- a/Lib/test/test_capi.py
+++ b/Lib/test/test_capi.py
@@ -8,6 +8,7 @@ import random
 import subprocess
 import sys
 import time
+import _thread
 import unittest
 from test import support
 try:
@@ -222,8 +223,34 @@ class EmbeddingTest(unittest.TestCase):
             os.chdir(oldcwd)
 
 
+@unittest.skipUnless(threading, 'Threading required for this test.')
+class TestThreadState(unittest.TestCase):
+
+    @support.reap_threads
+    def test_thread_state(self):
+        # some extra thread-state tests driven via _testcapi
+        def target():
+            idents = []
+
+            def callback():
+                idents.append(_thread.get_ident())
+
+            _testcapi._test_thread_state(callback)
+            a = b = callback
+            time.sleep(1)
+            # Check our main thread is in the list exactly 3 times.
+            self.assertEqual(idents.count(_thread.get_ident()), 3,
+                             "Couldn't find main thread correctly in the list")
+
+        target()
+        t = threading.Thread(target=target)
+        t.start()
+        t.join()
+
+
 def test_main():
-    support.run_unittest(CAPITest, TestPendingCalls, Test6012, EmbeddingTest)
+    support.run_unittest(CAPITest, TestPendingCalls, Test6012,
+                         EmbeddingTest, TestThreadState)
 
     for name in dir(_testcapi):
         if name.startswith('test_'):
@@ -232,32 +259,5 @@ def test_main():
                 print("internal", name)
             test()
 
-    # some extra thread-state tests driven via _testcapi
-    def TestThreadState():
-        if support.verbose:
-            print("auto-thread-state")
-
-        idents = []
-
-        def callback():
-            idents.append(_thread.get_ident())
-
-        _testcapi._test_thread_state(callback)
-        a = b = callback
-        time.sleep(1)
-        # Check our main thread is in the list exactly 3 times.
-        if idents.count(_thread.get_ident()) != 3:
-            raise support.TestFailed(
-                        "Couldn't find main thread correctly in the list")
-
-    if threading:
-        import _thread
-        import time
-        TestThreadState()
-        t = threading.Thread(target=TestThreadState)
-        t.start()
-        t.join()
-
-
 if __name__ == "__main__":
     test_main()
diff --git a/Misc/NEWS b/Misc/NEWS
index 5d768ce2e19..2e07923680c 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -936,6 +936,8 @@ Extension Modules
 Tests
 -----
 
+- Issue #17249: convert a test in test_capi to use unittest and reap threads.
+
 - Issue #17041: Fix testing when Python is configured with the
   --without-doc-strings.