diff --git a/Lib/test/test_capi.py b/Lib/test/test_capi.py index 5002c77b6a1..65778be501b 100644 --- a/Lib/test/test_capi.py +++ b/Lib/test/test_capi.py @@ -326,9 +326,34 @@ class SkipitemTest(unittest.TestCase): self.assertRaises(ValueError, _testcapi.parse_tuple_and_keywords, (), {}, b'', [42]) +@unittest.skipUnless(threading, 'Threading required for this test.') +class TestThreadState(unittest.TestCase): + + @support.reap_threads + def test_thread_state(self): + # some extra thread-state tests driven via _testcapi + def target(): + idents = [] + + def callback(): + idents.append(threading.get_ident()) + + _testcapi._test_thread_state(callback) + a = b = callback + time.sleep(1) + # Check our main thread is in the list exactly 3 times. + self.assertEqual(idents.count(threading.get_ident()), 3, + "Couldn't find main thread correctly in the list") + + target() + t = threading.Thread(target=target) + t.start() + t.join() + + def test_main(): - support.run_unittest(CAPITest, TestPendingCalls, - Test6012, EmbeddingTest, SkipitemTest) + support.run_unittest(CAPITest, TestPendingCalls, Test6012, + EmbeddingTest, SkipitemTest, TestThreadState) for name in dir(_testcapi): if name.startswith('test_'): @@ -337,31 +362,5 @@ def test_main(): print("internal", name) test() - # some extra thread-state tests driven via _testcapi - def TestThreadState(): - if support.verbose: - print("auto-thread-state") - - idents = [] - - def callback(): - idents.append(threading.get_ident()) - - _testcapi._test_thread_state(callback) - a = b = callback - time.sleep(1) - # Check our main thread is in the list exactly 3 times. - if idents.count(threading.get_ident()) != 3: - raise support.TestFailed( - "Couldn't find main thread correctly in the list") - - if threading: - import time - TestThreadState() - t = threading.Thread(target=TestThreadState) - t.start() - t.join() - - if __name__ == "__main__": test_main() diff --git a/Misc/NEWS b/Misc/NEWS index c91c3dd4a1e..07c86db10f7 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -857,6 +857,8 @@ Extension Modules Tests ----- +- Issue #17249: convert a test in test_capi to use unittest and reap threads. + - Issue #17107: Test client-side SNI support in urllib.request thanks to the new server-side SNI support in the ssl module. Initial patch by Daniel Black.