traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add XXX comments for whoever cleans up getargs.c :)

This commit is contained in:
Georg Brandl 2008-03-21 20:46:11 +00:00
parent 3888980408
commit 896c317b43
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Python/getargs.c
View File

@ -823,6 +823,9 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags,
} }
else else
return converterr("string", arg, msgbuf, bufsize); return converterr("string", arg, msgbuf, bufsize);
/* XXX(gb): this test is completely wrong -- p is a
* byte string while arg is a Unicode. I *think* it should
* check against the size of uarg... */
if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg)) if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
return converterr("string without null bytes", return converterr("string without null bytes",
arg, msgbuf, bufsize); arg, msgbuf, bufsize);
@ -898,6 +901,7 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags,
} }
format++; format++;
} }
/* XXX(gb): same comment as for 's' applies here... */
else if (*p != NULL && else if (*p != NULL &&
(Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg)) (Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
return converterr( return converterr(