inspect: Fix getcallargs() to raise correct TypeError

... for missing keyword-only arguments. Patch by Jeremiah Lowin.
Closes #20816.
This commit is contained in:
Yury Selivanov 2014-03-27 18:23:03 -04:00
parent 374375dd26
commit 875df20e8a
3 changed files with 12 additions and 1 deletions

View File

@ -1210,7 +1210,7 @@ def getcallargs(*func_and_positional, **named):
missing = 0
for kwarg in kwonlyargs:
if kwarg not in arg2value:
if kwarg in kwonlydefaults:
if kwonlydefaults and kwarg in kwonlydefaults:
arg2value[kwarg] = kwonlydefaults[kwarg]
else:
missing += 1

View File

@ -1208,6 +1208,14 @@ class TestGetcallargsFunctions(unittest.TestCase):
self.assertEqualException(f3, '1, 2')
self.assertEqualException(f3, '1, 2, a=1, b=2')
# issue #20816: getcallargs() fails to iterate over non-existent
# kwonlydefaults and raises a wrong TypeError
def f5(*, a): pass
with self.assertRaisesRegex(TypeError,
'missing 1 required keyword-only'):
inspect.getcallargs(f5)
class TestGetcallargsMethods(TestGetcallargsFunctions):
def setUp(self):

View File

@ -113,6 +113,9 @@ Library
- Issue #20378: Improve repr of inspect.Signature and inspect.Parameter.
- Issue #20816: Fix inspect.getcallargs() to raise correct TypeError for
missing keyword-only arguments. Patch by Jeremiah Lowin.
Documentation
-------------