traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) (GH-24041) 

(cherry picked from commit ec3165320e)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
This commit is contained in:
Miss Islington (bot) 2021-01-01 10:37:35 -08:00 committed by GitHub
parent 00278d4e61
commit 8200ee6669
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Lib/test/test_nntplib.py
View File

@ -82,7 +82,7 @@ class NetworkedNNTPTestsMixin:
desc = self.server.description(self.GROUP_NAME) desc = self.server.description(self.GROUP_NAME)
_check_desc(desc) _check_desc(desc)
# Another sanity check # Another sanity check
self.assertIn("Python", desc) self.assertIn(self.DESC, desc)
# With a pattern # With a pattern
desc = self.server.description(self.GROUP_PAT) desc = self.server.description(self.GROUP_PAT)
_check_desc(desc) _check_desc(desc)
@ -299,6 +299,7 @@ class NetworkedNNTPTests(NetworkedNNTPTestsMixin, unittest.TestCase):
NNTP_HOST = 'news.trigofacile.com' NNTP_HOST = 'news.trigofacile.com'
GROUP_NAME = 'fr.comp.lang.python' GROUP_NAME = 'fr.comp.lang.python'
GROUP_PAT = 'fr.comp.lang.*' GROUP_PAT = 'fr.comp.lang.*'
DESC = 'Python'
NNTP_CLASS = NNTP NNTP_CLASS = NNTP
@ -332,8 +333,11 @@ class NetworkedNNTP_SSLTests(NetworkedNNTPTests):
# 400 connections per day are accepted from each IP address." # 400 connections per day are accepted from each IP address."
NNTP_HOST = 'nntp.aioe.org' NNTP_HOST = 'nntp.aioe.org'
GROUP_NAME = 'comp.lang.python' # bpo-42794: aioe.test is one of the official groups on this server
GROUP_PAT = 'comp.lang.*' # used for testing: https://news.aioe.org/manual/aioe-hierarchy/
GROUP_NAME = 'aioe.test'
GROUP_PAT = 'aioe.*'
DESC = 'test'
NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None) NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None)

2
Misc/NEWS.d/next/Tests/2021-01-01-08-52-36.bpo-42794.-7-XGz.rst Normal file
View File

@ -0,0 +1,2 @@
Update test_nntplib to use offical group name of news.aioe.org for testing.
Patch by Dong-hee Na.