traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Address a minor Coverity warning re: unchecked PyArg_ParseTuple calls 

in socket.sendto().  A PyErr_Occurred() check was happening later, but
it is better to just use the return value and not call PyErr_Occurred().
This commit is contained in:
Gregory P. Smith 2017-01-17 16:54:56 -08:00
parent aeaf294608
commit 8128d5a491
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Modules/socketmodule.c
View File

@ -3863,11 +3863,15 @@ sock_sendto(PySocketSockObject *s, PyObject *args)
arglen = PyTuple_Size(args);
switch (arglen) {
case 2:
PyArg_ParseTuple(args, "y*O:sendto", &pbuf, &addro);
if (!PyArg_ParseTuple(args, "y*O:sendto", &pbuf, &addro)) {
return NULL;
}
break;
case 3:
PyArg_ParseTuple(args, "y*iO:sendto",
&pbuf, &flags, &addro);
if (!PyArg_ParseTuple(args, "y*iO:sendto",
&pbuf, &flags, &addro)) {
return NULL;
}
break;
default:
PyErr_Format(PyExc_TypeError,
@ -3875,8 +3879,6 @@ sock_sendto(PySocketSockObject *s, PyObject *args)
arglen);
return NULL;
}
if (PyErr_Occurred())
return NULL;
if (!IS_SELECTABLE(s)) {
PyBuffer_Release(&pbuf);