Fixes issue #19929: Call os.read with 32768 within subprocess.Popen

communicate rather than 4096 for efficiency.  A microbenchmark shows
Linux and OS X both using ~50% less cpu time this way.
This commit is contained in:
Gregory P. Smith 2013-12-08 10:58:28 -08:00
commit 7b83b18679
2 changed files with 5 additions and 1 deletions

View File

@ -1601,7 +1601,7 @@ class Popen(object):
selector.unregister(key.fileobj)
key.fileobj.close()
elif key.fileobj in (self.stdout, self.stderr):
data = os.read(key.fd, 4096)
data = os.read(key.fd, 32768)
if not data:
selector.unregister(key.fileobj)
key.fileobj.close()

View File

@ -24,6 +24,10 @@ Library
- Issue #19343: Expose FreeBSD-specific APIs in resource module. Original
patch by Koobs.
- Issue #19929: Call os.read with 32768 within subprocess.Popen.communicate
rather than 4096 for efficiency. A microbenchmark shows Linux and OS X
both using ~50% less cpu time this way.
- Issue #19506: Use a memoryview to avoid a data copy when piping data
to stdin within subprocess.Popen.communicate. 5-10% less cpu usage.