#7050 fix a SystemError when using tuple unpacking and augmented assignment

This commit is contained in:
Benjamin Peterson 2009-10-03 20:23:24 +00:00
parent 3b34dd871a
commit 7adbb5a35d
3 changed files with 19 additions and 0 deletions

View File

@ -24,6 +24,9 @@ class AugAssignTest(unittest.TestCase):
# new-style division (with -Qnew)
self.assertEquals(x, 3.0)
def test_with_unpacking(self):
self.assertRaises(SyntaxError, compile, "x, b += 3", "<test>", "exec")
def testInList(self):
x = [2]
x[0] += 1

View File

@ -12,6 +12,9 @@ What's New in Python 2.7 alpha 1
Core and Builtins
-----------------
- Issue #7050: Fix a SystemError when trying to use unpacking and augmented
assignment.
- Issue #5329: Fix os.popen* regression from 2.5 with commands as a
sequence running through the shell. Patch by Jean-Paul Calderone
and Jani Hakala.

View File

@ -2097,6 +2097,19 @@ ast_for_expr_stmt(struct compiling *c, const node *n)
return NULL;
if(!set_context(c, expr1, Store, ch))
return NULL;
/* set_context checks that most expressions are not the left side.
Augmented assignments can only have a name, a subscript, or an
attribute on the left, though, so we have to explicitly check for
those. */
switch (expr1->kind) {
case Name_kind:
case Attribute_kind:
case Subscript_kind:
break;
default:
ast_error(ch, "illegal expression for augmented assignment");
return NULL;
}
ch = CHILD(n, 2);
if (TYPE(ch) == testlist)