traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-40196: Fix a bug in the symtable when reporting inspecting global variables (GH-19391)

This commit is contained in:
Pablo Galindo 2020-04-06 17:05:57 +01:00 committed by GitHub
parent 38aefc585f
commit 799d7d61a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/symtable.py
View File

@ -197,7 +197,7 @@ class Symbol(object):
return bool(self.__scope == GLOBAL_EXPLICIT) return bool(self.__scope == GLOBAL_EXPLICIT)
def is_local(self): def is_local(self):
return bool(self.__flags & DEF_BOUND) return bool(self.__scope in (LOCAL, CELL))
def is_annotated(self): def is_annotated(self):
return bool(self.__flags & DEF_ANNOT) return bool(self.__flags & DEF_ANNOT)

6
Lib/test/test_symtable.py
View File

@ -99,6 +99,7 @@ class SymtableTest(unittest.TestCase):
self.assertTrue(self.spam.lookup("bar").is_declared_global()) self.assertTrue(self.spam.lookup("bar").is_declared_global())
self.assertFalse(self.internal.lookup("x").is_global()) self.assertFalse(self.internal.lookup("x").is_global())
self.assertFalse(self.Mine.lookup("instance_var").is_global()) self.assertFalse(self.Mine.lookup("instance_var").is_global())
self.assertTrue(self.spam.lookup("bar").is_global())
def test_nonlocal(self): def test_nonlocal(self):
self.assertFalse(self.spam.lookup("some_var").is_nonlocal()) self.assertFalse(self.spam.lookup("some_var").is_nonlocal())
@ -108,7 +109,10 @@ class SymtableTest(unittest.TestCase):
def test_local(self): def test_local(self):
self.assertTrue(self.spam.lookup("x").is_local()) self.assertTrue(self.spam.lookup("x").is_local())
self.assertFalse(self.internal.lookup("x").is_local()) self.assertFalse(self.spam.lookup("bar").is_local())
def test_free(self):
self.assertTrue(self.internal.lookup("x").is_free())
def test_referenced(self): def test_referenced(self):
self.assertTrue(self.internal.lookup("x").is_referenced()) self.assertTrue(self.internal.lookup("x").is_referenced())

2
Misc/NEWS.d/next/Library/2020-04-06-11-05-13.bpo-40196.Jqowse.rst Normal file
View File

@ -0,0 +1,2 @@
Fix a bug in the :mod:`symtable` module that was causing incorrectly report
global variables as local. Patch by Pablo Galindo.