traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702)

This commit is contained in:
Samuel Colvin 2019-10-13 12:45:36 +01:00 committed by Serhiy Storchaka
parent 140a7d1f35
commit 793cb85437
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Lib/dataclasses.py
View File

@ -206,7 +206,12 @@ class InitVar:
self.type = type self.type = type
def __repr__(self): def __repr__(self):
return f'dataclasses.InitVar[{self.type.__name__}]' if isinstance(self.type, type):
type_name = self.type.__name__
else:
# typing objects, e.g. List[int]
type_name = repr(self.type)
return f'dataclasses.InitVar[{type_name}]'
def __class_getitem__(cls, type): def __class_getitem__(cls, type):
return InitVar(type) return InitVar(type)

2
Lib/test/test_dataclasses.py
View File

@ -1102,6 +1102,8 @@ class TestCase(unittest.TestCase):
# Make sure the repr is correct. # Make sure the repr is correct.
self.assertEqual(repr(InitVar[int]), 'dataclasses.InitVar[int]') self.assertEqual(repr(InitVar[int]), 'dataclasses.InitVar[int]')
self.assertEqual(repr(InitVar[List[int]]),
'dataclasses.InitVar[typing.List[int]]')
def test_init_var_inheritance(self): def test_init_var_inheritance(self):
# Note that this deliberately tests that a dataclass need not # Note that this deliberately tests that a dataclass need not

1
Misc/NEWS.d/next/Library/2019-10-10-16-53-00.bpo-38431.d5wzNp.rst Normal file
View File

@ -0,0 +1 @@
Fix ``__repr__`` method for :class:`dataclasses.InitVar` to support typing objects, patch by Samuel Colvin.