Issue #21715: Extracted shared complicated code in the _io module to new
_PyErr_ChainExceptions() function.
This commit is contained in:
commit
78184af9b5
|
@ -123,7 +123,9 @@ PyAPI_FUNC(void) PyException_SetCause(PyObject *, PyObject *);
|
|||
/* Context manipulation (PEP 3134) */
|
||||
PyAPI_FUNC(PyObject *) PyException_GetContext(PyObject *);
|
||||
PyAPI_FUNC(void) PyException_SetContext(PyObject *, PyObject *);
|
||||
|
||||
#ifndef Py_LIMITED_API
|
||||
PyAPI_FUNC(void) _PyErr_ChainExceptions(PyObject *, PyObject *, PyObject *);
|
||||
#endif
|
||||
|
||||
/* */
|
||||
|
||||
|
|
|
@ -458,19 +458,8 @@ io_open(PyObject *self, PyObject *args, PyObject *kwds)
|
|||
PyObject *exc, *val, *tb, *close_result;
|
||||
PyErr_Fetch(&exc, &val, &tb);
|
||||
close_result = _PyObject_CallMethodId(result, &PyId_close, NULL);
|
||||
if (close_result != NULL) {
|
||||
Py_DECREF(close_result);
|
||||
PyErr_Restore(exc, val, tb);
|
||||
} else {
|
||||
PyObject *exc2, *val2, *tb2;
|
||||
PyErr_Fetch(&exc2, &val2, &tb2);
|
||||
PyErr_NormalizeException(&exc, &val, &tb);
|
||||
Py_XDECREF(exc);
|
||||
Py_XDECREF(tb);
|
||||
PyErr_NormalizeException(&exc2, &val2, &tb2);
|
||||
PyException_SetContext(val2, val);
|
||||
PyErr_Restore(exc2, val2, tb2);
|
||||
}
|
||||
_PyErr_ChainExceptions(exc, val, tb);
|
||||
Py_XDECREF(close_result);
|
||||
Py_DECREF(result);
|
||||
}
|
||||
Py_XDECREF(modeobj);
|
||||
|
|
|
@ -561,20 +561,8 @@ buffered_close(buffered *self, PyObject *args)
|
|||
}
|
||||
|
||||
if (exc != NULL) {
|
||||
if (res != NULL) {
|
||||
Py_CLEAR(res);
|
||||
PyErr_Restore(exc, val, tb);
|
||||
}
|
||||
else {
|
||||
PyObject *exc2, *val2, *tb2;
|
||||
PyErr_Fetch(&exc2, &val2, &tb2);
|
||||
PyErr_NormalizeException(&exc, &val, &tb);
|
||||
Py_DECREF(exc);
|
||||
Py_XDECREF(tb);
|
||||
PyErr_NormalizeException(&exc2, &val2, &tb2);
|
||||
PyException_SetContext(val2, val);
|
||||
PyErr_Restore(exc2, val2, tb2);
|
||||
}
|
||||
_PyErr_ChainExceptions(exc, val, tb);
|
||||
Py_CLEAR(res);
|
||||
}
|
||||
|
||||
end:
|
||||
|
|
|
@ -2614,20 +2614,8 @@ textiowrapper_close(textio *self, PyObject *args)
|
|||
|
||||
res = _PyObject_CallMethodId(self->buffer, &PyId_close, NULL);
|
||||
if (exc != NULL) {
|
||||
if (res != NULL) {
|
||||
Py_CLEAR(res);
|
||||
PyErr_Restore(exc, val, tb);
|
||||
}
|
||||
else {
|
||||
PyObject *exc2, *val2, *tb2;
|
||||
PyErr_Fetch(&exc2, &val2, &tb2);
|
||||
PyErr_NormalizeException(&exc, &val, &tb);
|
||||
Py_DECREF(exc);
|
||||
Py_XDECREF(tb);
|
||||
PyErr_NormalizeException(&exc2, &val2, &tb2);
|
||||
PyException_SetContext(val2, val);
|
||||
PyErr_Restore(exc2, val2, tb2);
|
||||
}
|
||||
_PyErr_ChainExceptions(exc, val, tb);
|
||||
Py_CLEAR(res);
|
||||
}
|
||||
return res;
|
||||
}
|
||||
|
|
|
@ -384,6 +384,30 @@ PyErr_SetExcInfo(PyObject *p_type, PyObject *p_value, PyObject *p_traceback)
|
|||
Py_XDECREF(oldtraceback);
|
||||
}
|
||||
|
||||
/* Like PyErr_Restore(), but if an exception is already set,
|
||||
set the context associated with it.
|
||||
*/
|
||||
void
|
||||
_PyErr_ChainExceptions(PyObject *exc, PyObject *val, PyObject *tb)
|
||||
{
|
||||
if (exc == NULL)
|
||||
return;
|
||||
|
||||
if (PyErr_Occurred()) {
|
||||
PyObject *exc2, *val2, *tb2;
|
||||
PyErr_Fetch(&exc2, &val2, &tb2);
|
||||
PyErr_NormalizeException(&exc, &val, &tb);
|
||||
Py_DECREF(exc);
|
||||
Py_XDECREF(tb);
|
||||
PyErr_NormalizeException(&exc2, &val2, &tb2);
|
||||
PyException_SetContext(val2, val);
|
||||
PyErr_Restore(exc2, val2, tb2);
|
||||
}
|
||||
else {
|
||||
PyErr_Restore(exc, val, tb);
|
||||
}
|
||||
}
|
||||
|
||||
/* Convenience functions to set a type error exception and return 0 */
|
||||
|
||||
int
|
||||
|
|
Loading…
Reference in New Issue