traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Issue #16234: Modify sha3's block_size method to return NotImplemented. 

This makes the sha3 types unusable from the hmac module. HMAC-SHA3 hasn't been specified yet.
This commit is contained in:
Christian Heimes 2012-10-14 22:16:27 +02:00
parent 11dc6c311d
commit 7707f6fd32
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Modules/_sha3/sha3module.c
View File

@ -140,7 +140,7 @@
#include "keccak/KeccakF-1600-opt32.c"
#endif
#define SHA3_BLOCKSIZE 200 /* 1600 bits */
/* #define SHA3_BLOCKSIZE 200 // 1600 bits */
#define SHA3_MAX_DIGESTSIZE 64 /* 512 bits */
#define SHA3_state hashState
#define SHA3_init Init
@ -367,7 +367,11 @@ static PyMethodDef SHA3_methods[] = {
static PyObject *
SHA3_get_block_size(SHA3object *self, void *closure)
{
return PyLong_FromLong(SHA3_BLOCKSIZE);
/* HMAC-SHA3 hasn't been specified yet and no official test vectors are
* available. Thus block_size returns NotImplemented to prevent people
* from using SHA3 with the hmac module.
*/
Py_RETURN_NOTIMPLEMENTED;
}
static PyObject *