inspect.signature: Add support for decorated (wrapped) builtins #20425

This commit is contained in:
Yury Selivanov 2014-01-29 10:52:57 -05:00
parent b77511da92
commit 76c6c593ed
2 changed files with 18 additions and 3 deletions

View File

@ -1530,9 +1530,6 @@ def signature(obj):
if not callable(obj):
raise TypeError('{!r} is not a callable object'.format(obj))
if _signature_is_builtin(obj):
return Signature.from_builtin(obj)
if isinstance(obj, types.MethodType):
# In this case we skip the first parameter of the underlying
# function (usually `self` or `cls`).
@ -1570,6 +1567,9 @@ def signature(obj):
return sig.replace(parameters=new_params)
if _signature_is_builtin(obj):
return Signature.from_builtin(obj)
if isinstance(obj, types.FunctionType):
return Signature.from_function(obj)

View File

@ -1655,6 +1655,21 @@ class TestSignatureObject(unittest.TestCase):
__call__ = type
test_callable(ThisWorksNow())
@unittest.skipIf(MISSING_C_DOCSTRINGS,
"Signature information for builtins requires docstrings")
def test_signature_on_decorated_builtins(self):
func = _testcapi.docstring_with_signature_with_defaults
def decorator(func):
@functools.wraps(func)
def wrapper(*args, **kwargs) -> int:
return func(*args, **kwargs)
return wrapper
decorated_func = decorator(func)
self.assertEqual(inspect.signature(func),
inspect.signature(decorated_func))
def test_signature_on_builtins_no_signature(self):
with self.assertRaisesRegex(ValueError, 'no signature found for builtin'):