Live with that "the hardware address" is an ill-defined

concept, and that different ways of trying to find "the
hardware address" may return different results.  Certainly
true on both of my Windows boxes, and in different ways
(see whining on python-dev).
This commit is contained in:
Tim Peters 2006-07-28 04:51:59 +00:00
parent df80af7659
commit 750c4420a8
3 changed files with 38 additions and 20 deletions

View File

@ -109,10 +109,13 @@ when the variant is \constant{RFC_4122}).
The \module{uuid} module defines the following functions The \module{uuid} module defines the following functions
\begin{funcdesc}{getnode}{} \begin{funcdesc}{getnode}{}
Get the hardware address as a 48-bit integer. The first time this runs, Get the hardware address as a 48-bit positive integer. The first time this
it may launch a separate program, which could be quite slow. If all runs, it may launch a separate program, which could be quite slow. If all
attempts to obtain the hardware address fail, we choose a random 48-bit attempts to obtain the hardware address fail, we choose a random 48-bit
number with its eighth bit set to 1 as recommended in RFC 4122. number with its eighth bit set to 1 as recommended in RFC 4122. "Hardware
address" means the MAC address of a network interface, and on a machine
with multiple network interfaces the MAC address of any one of them may
be returned.
\end{funcdesc} \end{funcdesc}
\index{getnode} \index{getnode}

View File

@ -284,7 +284,11 @@ class TestUUID(TestCase):
msg = "different sources disagree on node:\n" msg = "different sources disagree on node:\n"
for s, n in TestUUID.source2node.iteritems(): for s, n in TestUUID.source2node.iteritems():
msg += " from source %r, node was %012x\n" % (s, n) msg += " from source %r, node was %012x\n" % (s, n)
self.fail(msg) # There's actually no reason to expect the MAC addresses
# to agree across various methods -- e.g., a box may have
# multiple network interfaces, and different ways of getting
# a MAC address may favor different HW.
##self.fail(msg)
else: else:
TestUUID.last_node = node TestUUID.last_node = node
@ -309,7 +313,7 @@ class TestUUID(TestCase):
def test_random_getnode(self): def test_random_getnode(self):
node = uuid._random_getnode() node = uuid._random_getnode()
self.assert_(0 <= node) self.assert_(0 <= node)
self.assert_(node < 1<<48L) self.assert_(node < (1L <<48))
def test_unixdll_getnode(self): def test_unixdll_getnode(self):
import os import os
@ -322,10 +326,14 @@ class TestUUID(TestCase):
self.check_node(uuid._windll_getnode(), 'windll') self.check_node(uuid._windll_getnode(), 'windll')
def test_getnode(self): def test_getnode(self):
self.check_node(uuid.getnode(), "getnode1") node1 = uuid.getnode()
self.check_node(node1, "getnode1")
# Test it again to ensure consistency. # Test it again to ensure consistency.
self.check_node(uuid.getnode(), "getnode2") node2 = uuid.getnode()
self.check_node(node2, "getnode2")
self.assertEqual(node1, node2)
def test_uuid1(self): def test_uuid1(self):
equal = self.assertEqual equal = self.assertEqual

View File

@ -362,6 +362,10 @@ try:
# hardware address. On Windows 2000 and later, UuidCreate makes a # hardware address. On Windows 2000 and later, UuidCreate makes a
# random UUID and UuidCreateSequential gives a UUID containing the # random UUID and UuidCreateSequential gives a UUID containing the
# hardware address. These routines are provided by the RPC runtime. # hardware address. These routines are provided by the RPC runtime.
# NOTE: at least on Tim's WinXP Pro SP2 desktop box, while the last
# 6 bytes returned by UuidCreateSequential are fixed, they don't appear
# to bear any relationship to the MAC address of any network device
# on the box.
try: try:
lib = ctypes.windll.rpcrt4 lib = ctypes.windll.rpcrt4
except: except:
@ -389,10 +393,13 @@ def _random_getnode():
_node = None _node = None
def getnode(): def getnode():
"""Get the hardware address as a 48-bit integer. The first time this """Get the hardware address as a 48-bit positive integer.
runs, it may launch a separate program, which could be quite slow. If
all attempts to obtain the hardware address fail, we choose a random The first time this runs, it may launch a separate program, which could
48-bit number with its eighth bit set to 1 as recommended in RFC 4122.""" be quite slow. If all attempts to obtain the hardware address fail, we
choose a random 48-bit number with its eighth bit set to 1 as recommended
in RFC 4122.
"""
global _node global _node
if _node is not None: if _node is not None: