traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Closes #13661: Check added for type of logger name.

This commit is contained in:
Vinay Sajip 2011-11-07 08:49:16 +00:00
parent caf0272d40
commit 74ab3440ba
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/logging/__init__.py
View File

@ -1007,6 +1007,8 @@ class Manager(object):
placeholder to now point to the logger. placeholder to now point to the logger.
""" """
rv = None rv = None
if not isinstance(name, basestring):
raise ValueError('A logger name must be string or Unicode')
if isinstance(name, unicode): if isinstance(name, unicode):
name = name.encode('utf-8') name = name.encode('utf-8')
_acquireLock() _acquireLock()

2
Lib/test/test_logging.py
View File

@ -272,6 +272,8 @@ class BuiltinLevelsTest(BaseTest):
('INF.BADPARENT', 'INFO', '4'), ('INF.BADPARENT', 'INFO', '4'),
]) ])
def test_invalid_name(self):
self.assertRaises(ValueError, logging.getLogger, any)
class BasicFilterTest(BaseTest): class BasicFilterTest(BaseTest):