traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-34435: Add missing NULL check to unicode_encode_ucs1(). (GH-8823) 

Reported by Svace static analyzer.
This commit is contained in:
Alexey Izbyshev 2018-08-19 21:52:04 +03:00 committed by Serhiy Storchaka
parent 225b055480
commit 74a307d48e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Objects/unicodeobject.c
View File

@ -6813,8 +6813,6 @@ unicode_encode_ucs1(PyObject *unicode,
str = _PyBytesWriter_WriteBytes(&writer, str, str = _PyBytesWriter_WriteBytes(&writer, str,
PyBytes_AS_STRING(rep), PyBytes_AS_STRING(rep),
PyBytes_GET_SIZE(rep)); PyBytes_GET_SIZE(rep));
if (str == NULL)
goto onError;
} }
else { else {
assert(PyUnicode_Check(rep)); assert(PyUnicode_Check(rep));
@ -6836,6 +6834,9 @@ unicode_encode_ucs1(PyObject *unicode,
PyUnicode_DATA(rep), PyUnicode_DATA(rep),
PyUnicode_GET_LENGTH(rep)); PyUnicode_GET_LENGTH(rep));
} }
if (str == NULL)
goto onError;
pos = newpos; pos = newpos;
Py_CLEAR(rep); Py_CLEAR(rep);
} }