traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-31174: Improve the code of test_tools.test_unparse. (#4146)

This commit is contained in:
Serhiy Storchaka 2017-10-27 15:35:11 +03:00 committed by GitHub
parent 03eb11f0b3
commit 7351f9e5a9
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Lib/test/test_tools/test_unparse.py
View File

@ -268,12 +268,13 @@ class DirectoryTestCase(ASTTestCase):
# test directories, relative to the root of the distribution # test directories, relative to the root of the distribution
test_directories = 'Lib', os.path.join('Lib', 'test') test_directories = 'Lib', os.path.join('Lib', 'test')
def get_names(self): @classmethod
if DirectoryTestCase.NAMES is not None: def get_names(cls):
return DirectoryTestCase.NAMES if cls.NAMES is not None:
return cls.NAMES
names = [] names = []
for d in self.test_directories: for d in cls.test_directories:
test_dir = os.path.join(basepath, d) test_dir = os.path.join(basepath, d)
for n in os.listdir(test_dir): for n in os.listdir(test_dir):
if n.endswith('.py') and not n.startswith('bad'): if n.endswith('.py') and not n.startswith('bad'):
@ -282,10 +283,9 @@ class DirectoryTestCase(ASTTestCase):
# Test limited subset of files unless the 'cpu' resource is specified. # Test limited subset of files unless the 'cpu' resource is specified.
if not test.support.is_resource_enabled("cpu"): if not test.support.is_resource_enabled("cpu"):
names = random.sample(names, 10) names = random.sample(names, 10)
# bpo-31174: Store the names sample to always test the same files. # bpo-31174: Store the names sample to always test the same files.
# It prevents false alarms when hunting reference leaks. # It prevents false alarms when hunting reference leaks.
DirectoryTestCase.NAMES = names cls.NAMES = names
return names return names
def test_files(self): def test_files(self):